Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Onnx >= to == #20798

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix Onnx >= to == #20798

merged 1 commit into from
May 24, 2024

Conversation

jchen351
Copy link
Contributor

Description

Motivation and Context

snnn
snnn approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we should prefer to use "==" instead of ">=", unless we are pretty sure a new version of the package would not break our pipeline.

@jchen351 jchen351 merged commit 10c425a into main May 24, 2024
96 of 98 checks passed
@jchen351 jchen351 deleted the Cjian/onnx-fix branch May 24, 2024 16:16
@sophies927 sophies927 added the triage:approved Approved for cherrypicks for release label Jun 12, 2024
yf711 pushed a commit that referenced this pull request Jun 18, 2024
@jchen351 @yf711
Fix Onnx >= to == (#20798)
05792b1 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
yf711 pushed a commit that referenced this pull request Jun 18, 2024
@jchen351 @yf711
Fix Onnx >= to == (#20798)
0878f44 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snnn snnn snnn approved these changes

@tianleiwu tianleiwu tianleiwu approved these changes

Assignees
No one assigned
Labels
release:1.18.1 triage:approved Approved for cherrypicks for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jchen351 @snnn @tianleiwu @sophies927 @yf711