Replace inline pip install with pip install from requirements*.txt #21106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
snnn
reviewed
Jun 19, 2024
snnn
reviewed
Jun 19, 2024
| wheel | ||
| pytest | ||
| numpy==1.24.0 ; python_version < '3.12' | ||
| numpy==1.26.0 ; python_version >= '3.12' |
There was a problem hiding this comment.
I have a PR(#21085) that updates Numpy to a newer version. Could you wait it? I think we have conflicts here.
There was a problem hiding this comment.
update to numpy >= 1.19.0, same as your PR.
snnn
reviewed
Jun 19, 2024
tools/ci_build/build.py
Outdated
| dep_packages.append("cerberus") | ||
| dep_packages.append("psutil") | ||
| run_subprocess([sys.executable, "-m", "pip", "install", *dep_packages]) | ||
| def install_python_deps(requirements_file='requirements.txt',numpy_version=None): |
There was a problem hiding this comment.
Or maybe we can totally remove this function.
There was a problem hiding this comment.
Do we want to keep the NumPy version overwritten capability? We can remove the function unless we don't want this capability.
There was a problem hiding this comment.
We could just use the latest numpy
jchen351
commented
Jun 20, 2024
| @@ -260,9 +260,6 @@ def convert_arg_line_to_args(self, arg_line): | |||
| "--wheel_name_suffix", | |||
| help="Suffix to append to created wheel names. This value is currently only used for nightly builds.", | |||
| ) | |||
| parser.add_argument( | |||
There was a problem hiding this comment.
The only place that uses this argument was from line 2813, which is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace inline pip install with pip install from requirements*.txt
Motivation and Context
so that CG can recognize
Dependency