Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep QDQ nodes w/ nonpositive scale around MaxPool #21182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Keep QDQ nodes w/ nonpositive scale around MaxPool #21182

wants to merge 2 commits into from

Commits on Jun 26, 2024

  1. Keep QDQ nodes w/ nonpositive scale around MaxPool 

    Currently, the DropQDQNodesRules optimization removes QuantizeLinear and
DequantizeLinear nodes from DequantizeLinear∘MaxPool∘QuantizeLinear.
However, if the x_scale/y_scale values are non-positive, this changes
the ordering of the elements in the input value, so this optimization is
changing the results.

This change adds a check for whether the scale in the QuantizeLinear (or
DequantizeLinear) is a positive scalar, and a new selector to disallow
removing the QDQ around MaxPool if it is not.

microsoft#21176
    @mcollinswisc
    mcollinswisc committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2160e44 View commit details
    Browse the repository at this point in the history

  2. Unit test on QDQ w/ nonpositive scale around MaxPool

    @mcollinswisc
    mcollinswisc committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    61c5d84 View commit details
    Browse the repository at this point in the history