Delete path.h #21211
Merged
Delete path.h #21211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
requested review from
mszhanyi,
edgchen1,
jchen351,
tianleiwu and
baijumeswani
mszhanyi
previously approved these changes
Jul 3, 2024
mszhanyi
reviewed
Jul 3, 2024
onnxruntime/test/debug_node_inputs_outputs/debug_node_inputs_outputs_utils_test.cc
Outdated
Show resolved
Hide resolved
onnxruntime/test/debug_node_inputs_outputs/debug_node_inputs_outputs_utils_test.cc
Outdated
Show resolved
Hide resolved
mszhanyi
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete path.h and replace all occurrences of onnxruntime::Path with std::filesystem::path.
Previously we couldn't use C++17's std::filesystem because it was not supported in iOS 12(which was released in 2018). Now we dropped the support for iOS 12.
Motivation and Context
To simplify code. For example, if an EP wants to use the Path class, now it can directly use it without going through a wrapper. And the standard implementation can handle various path types better. (We didn't take much consideration on UNC path, "/" as a path separator on Windows, etc).