Establish (and use) a strerror() replacement for safety #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, signing off. |
srupiett
pushed a commit
to srupiett/pal
that referenced
this pull request
Dec 1, 2022
* policheck fixes * policheck fixes scxlvmutils.cpp
srupiett
pushed a commit
to srupiett/pal
that referenced
this pull request
Dec 1, 2022
Yashkhatri/policheck fixes (microsoft#10)
JumpingYang001
pushed a commit
that referenced
this pull request
Dec 13, 2022
* policheck fixes * policheck fixes scxlvmutils.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new SCXCoreLib::strerror() function, compatible with the system ::strerror() function, but safe on all platforms (except old HP, where we can't do anything about it since strerror_r() isn't available).
Note that unit tests for this new function are not needed. The basis for this code came from scxexception.h, and the code is called directly from scxexception.h. Since scxexception.h has great unit tests that call the new code, it's directly tested.
@Microsoft/ostc-devs