Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dictionary unpacking for classes that don't explicitly derive from Mapping #4826

Closed
erictraut opened this issue Mar 22, 2023 · 1 comment
Closed

Support dictionary unpacking for classes that don't explicitly derive from Mapping #4826

erictraut opened this issue Mar 22, 2023 · 1 comment
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request

Comments

@erictraut
Copy link
Collaborator

See this python/typing discussion forum thread.

We can use the SupportsKeysAndGetItem protocol to determine whether a type supports dictionary unpacking.
@erictraut erictraut added the enhancement request New feature or request label Mar 22, 2023
erictraut pushed a commit that referenced this issue Mar 22, 2023
@msfterictraut
Added support for argument dictionary unpacking when the type of the …
903fd3c 
…unpacked object supports the SupportsKeysAndGetItem protocol. Previously, the object needed to be an explicit subclass of Mapping. This addresses #4826.
@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label Mar 22, 2023
@erictraut
Copy link
Collaborator Author

This is included in pyright 1.1.301, which I just published. It will also be included in a future release of pylance.

This was referenced Mar 30, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erictraut