Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Desktop NUSPEC to use ARM64EC #13335

Merged
merged 12 commits into from
Jul 10, 2024

Conversation

JunielKatarn
Copy link
Contributor

@JunielKatarn JunielKatarn commented Jun 11, 2024

Description

Add ARM64EC platform to Desktop NuGet.

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Currently the Desktop NUSPEC OfficeReact.Win32.nuspec expects source and target paths for ARM64.

What

Change the NUSPEC entries from ARM64 to ARM64EC.

Microsoft Reviewers: Open in CodeFlow

@JunielKatarn JunielKatarn requested review from a team as code owners June 11, 2024 18:59
Copy link

@jeffstall jeffstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to have both ARM64 and ARM64EC builds. We can't replace one with the other. There's usage cases for both. Can you please update?

.ado/publish.yml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Jun 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) no-recent-activity Issue/PR has gone stale and may be closed (label applied by bot) labels Jun 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Jul 1, 2024
@vmoroz vmoroz self-requested a review July 9, 2024 21:43
@JunielKatarn JunielKatarn enabled auto-merge (squash) July 9, 2024 21:44
@JunielKatarn JunielKatarn merged commit 56ba478 into microsoft:main Jul 10, 2024
57 checks passed
@JunielKatarn JunielKatarn deleted the arm64ec-nuget branch July 10, 2024 00:51
JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC

* Change files

* Enable ARM64EC ReactWindows CI artifact

* Add ARM64EC|Release to nuget-desktop.yml

* Revert ARM64EC for ReactWindows artifact

* Exclude ARM64EC React.Windows.Desktop.Test.DLL from NUSPEC
JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC

* Change files

* Enable ARM64EC ReactWindows CI artifact

* Add ARM64EC|Release to nuget-desktop.yml

* Revert ARM64EC for ReactWindows artifact

* Exclude ARM64EC React.Windows.Desktop.Test.DLL from NUSPEC
JunielKatarn added a commit that referenced this pull request Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC (#13335)

* Increase Desktop job timeouts due to #13442 (#13444)

---------

Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com>
JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC

* Change files

* Enable ARM64EC ReactWindows CI artifact

* Add ARM64EC|Release to nuget-desktop.yml

* Revert ARM64EC for ReactWindows artifact

* Exclude ARM64EC React.Windows.Desktop.Test.DLL from NUSPEC
JunielKatarn added a commit that referenced this pull request Jul 19, 2024
* Port Desktop DLL to ARM64EC (#13320)

* Upgrade WinSDK version for C/C++ projects

* Do not build Integration Test projects for ARM64EC

* Make V8Platform x64 for ARM64EC

* Override HermesPlatform for ARM64EC

* Override WinAppSDK platforms for ARM64EC

* Exclude OpenSSL on Desktop DLL for ARM64EC

* Override WinAppSDK _MrtCoreRuntimeIdentifier

* Add explicit LIB dependencies for ARM64EC

* Skip React.Windows.IntegrationTests on ARM64EC

* Remove OpenSSL from Desktop LIB and DLL

* /t:Vars - Log SolutionName

* Update Desktop NUSPEC to use ARM64EC (#13335)

* Add ARM64EC strip slices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants