.Net: The Type property is added to the ParameterView class #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal team to analyze OpenAPI operation parameter types.
shawncal
added
.NET
dmytrostruk
approved these changes
Aug 3, 2023
dotnet/src/Skills/Skills.UnitTests/OpenAPI/Extensions/KernelOpenApiExtensionsTests.cs
Outdated
Show resolved
Hide resolved
…enApiExtensionsTests.cs Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
dmytrostruk
added
the
PR: ready to merge
shawncal
reviewed
Aug 4, 2023
dotnet/src/SemanticKernel.Abstractions/SkillDefinition/ParameterView.cs
Outdated
Show resolved
Hide resolved
…//github.com/SergeyMenshykh/semantic-kernel into advertise-open-api-operation-parameters-type
…sync obsolete one
shawncal
approved these changes
Aug 4, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
…t#2305) ### Motivation and Context This change was requested by an internal team to enable access to OpenAPI operation parameter types without parsing the OpenAPI documents themselves. ### Description This PR extends the ParameterView class with a new Type property, which is assigned from the OpenAPI operation parameter type. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change was requested by an internal team to enable access to OpenAPI operation parameter types without parsing the OpenAPI documents themselves.
Description
This PR extends the ParameterView class with a new Type property, which is assigned from the OpenAPI operation parameter type.
Contribution Checklist