-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending list of retryable codes #786
Extending list of retryable codes #786
Conversation
dotnet/src/SemanticKernel.Abstractions/Reliability/HttpRetryConfig.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Reliability/HttpRetryConfig.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Reliability/HttpRetryConfig.cs
Outdated
Show resolved
Hide resolved
Should we consider: 425(Too Early)? |
Not sure about 425 one because it's related to a specific scenario when a client wants to send data in advance of the secure connection being set up to optimize the time required for TLS to create a secure connection. There're no clear guidelines about the 507 one. Some sources say that it's a temporary issue implying that it can be retried the other ones say that it should not be retried in a scope of the same action? Taking into account that it's always possible to add any additional status code when configuring Kernel, I would not add these codes now, and wait until they are requested be a default ones. |
Good callout - we'll use this PR to align with MS practices, but I would welcome an issue for 425/507 |
### Motivation, Context and Description This change is required to improve SK SDK resilience while working with REST API by extending list of HTTP status codes DefaultHttpRetryHandler retries on.
### Motivation, Context and Description This change is required to improve SK SDK resilience while working with REST API by extending list of HTTP status codes DefaultHttpRetryHandler retries on.
Motivation, Context and Description
This change is required to improve SK SDK resilience while working with REST API by extending list of HTTP status codes DefaultHttpRetryHandler retries on.
Contribution Checklist
dotnet format