Benchmarks: Microbenchmark - Support in-place for NCCL/RCCL benchmark #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukirora
reviewed
Dec 11, 2023
cp5555
reviewed
Dec 11, 2023
superbench/benchmarks/micro_benchmarks/cuda_nccl_bw_performance.py
Outdated
Show resolved
Hide resolved
yzygitzh
force-pushed
the
ziyue/add-in-place-for-nccl
branch
from
55aaee1
to
9106e32
Compare
cp5555
added
benchmarks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.10 #591 +/- ##
================================================
+ Coverage 86.11% 86.12% +0.01%
================================================
Files 97 97
Lines 6873 6878 +5
================================================
+ Hits 5919 5924 +5
Misses 954 954
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yukirora
reviewed
Dec 12, 2023
tests/benchmarks/micro_benchmarks/test_cuda_nccl_bw_performance.py
Outdated
Show resolved
Hide resolved
cp5555
approved these changes
Dec 12, 2023
yzygitzh
force-pushed
the
ziyue/add-in-place-for-nccl
branch
from
2a32186
to
203776b
Compare
yukirora
approved these changes
Dec 13, 2023
cp5555
changed the title
abuccts
pushed a commit
that referenced
this pull request
Jan 3, 2024
…#591) **Description** Add in-place metrics for NCCL/RCCL benchmark for latency measurement.
abuccts
added a commit
that referenced
this pull request
Jan 8, 2024
**Description** Cherry-pick bug fixes from v0.10.0 to main. **Major Revisions** * Benchmarks: Microbenchmark - Support different hipblasLt data types in dist_inference #590 * Benchmarks: Microbenchmark - Support in-place for NCCL/RCCL benchmark #591 * Bug Fix - Fix NUMA Domains Swap Issue in NDv4 Topology File #592 * Benchmarks: Microbenchmark - Add data type option for NCCL and RCCL tests #595 * Benchmarks: Bug Fix - Make metrics of dist-inference-cpp aligned with PyTorch version #596 * CI/CD - Add ndv5 topo file #597 * Benchmarks: Microbenchmark - Improve AMD GPU P2P performance with fine-grained GPU memory #593 * Benchmarks: Build Pipeline - fix nccl and nccl test version to 2.18.3 to resolve hang issue in cuda12.2 docker #599 * Dockerfile - Bug fix for rocm docker build and deploy #598 * Benchmarks: Microbenchmark - Adapt to hipblasLt data type changes #603 * Benchmarks: Micro benchmarks - Update hipblaslt metric unit to tflops #604 * Monitor - Upgrade pyrsmi to amdsmi python library. #601 * Benchmarks: Micro benchmarks - add fp8 and initialization for hipblaslt benchmark #605 * Dockerfile - Add rocm6.0 dockerfile #602 * Bug Fix - Bug fix for latest megatron-lm benchmark #600 * Docs - Upgrade version and release note #606 Co-authored-by: Ziyue Yang <ziyyang@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Yuting Jiang <yutingjiang@microsoft.com> Co-authored-by: guoshzhao <guzhao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add in-place metrics for NCCL/RCCL benchmark for latency measurement.