Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unfocused appearance editor not appearing/disappearing correctly #10675

Merged
2 commits merged into from
Jul 16, 2021

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

Sends the additional xaml notification when the user presses the '+' or delete button for unfocused appearances

PR Checklist

Validation Steps Performed

It works now

@ghost ghost added Area-Settings UI Anything specific to the SUI Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jul 15, 2021
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp. That's an easy fix.

@PankajBhojwani PankajBhojwani added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 16, 2021
@ghost
Copy link

ghost commented Jul 16, 2021

Hello @PankajBhojwani!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 293c36d into main Jul 16, 2021
@ghost ghost deleted the dev/pabhoj/sui_unfocused_fix branch July 16, 2021 17:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unfocused Appearance editor doesn't appear on +, disappear on Deletion
4 participants