Allow preview connection to take in a preview string to display #13293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it possible to display the color table without using a terminal control? Just static XAML textblocks on top of static colors... would be much cheaper :) |
That probably makes more sense, closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When only the Profiles->Appearance page was using a preview control, it was okay to have a predefined 'preview' string that the preview control would display. Now that the ColorSchemes page also wants a preview control (to showcase all 16 colors), it makes sense to allow the page that is creating the preview control to decide what the preview string should be. So, the preview connection now takes in a preview string.
References
This is a prerequisite for #13269
PR Checklist
Validation Steps Performed
Profiles->Appearance preview control still works as before