Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing settings to the settings UI #8774

Merged
10 commits merged into from
Jan 14, 2021
Merged

Add missing settings to the settings UI #8774

10 commits merged into from
Jan 14, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jan 13, 2021 •
edited by DHowett
Loading

Adds the tab switcher mode setting and copy format setting to the SUI

Closes #8755

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jan 13, 2021
@PankajBhojwani PankajBhojwani marked this pull request as ready for review January 13, 2021 18:26
@DHowett
Copy link
Member

DHowett commented Jan 14, 2021

Validation Steps Performed

tabswithcermode

cinnamon-msft
cinnamon-msft suggested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@cinnamon-msft cinnamon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some wordsmithing :)

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 14, 2021
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 14, 2021
@PankajBhojwani
Copy link
Contributor Author

Added some wordsmithing :)

Thank you! Fixed

@PankajBhojwani PankajBhojwani added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

Hello @PankajBhojwani!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

cinnamon-msft
cinnamon-msft suggested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@cinnamon-msft cinnamon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait actually, alwaysOnTop should be an appearance setting, rather than a startup setting.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 14, 2021
@cinnamon-msft cinnamon-msft removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 14, 2021
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 14, 2021
@PankajBhojwani PankajBhojwani added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 14, 2021
@ghost ghost merged commit f7b5ff3 into main Jan 14, 2021
@ghost ghost deleted the dev/pabhoj/missing_settings branch January 14, 2021 23:58
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@PankajBhojwani @mpela81
Add missing settings to the settings UI (microsoft#8774)
650216b 
Adds the tab switcher mode setting and copy format setting to the SUI

Closes microsoft#8755
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett left review comments

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@cinnamon-msft cinnamon-msft cinnamon-msft approved these changes

Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Settings UI Settings
4 participants
@PankajBhojwani @DHowett @carlos-zamora @cinnamon-msft