Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Global settings a bit #8783

Merged
2 commits merged into from
Jan 14, 2021
Merged

Polish Global settings a bit #8783

2 commits merged into from
Jan 14, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jan 13, 2021

Polish for global settings in SUI

  • Launch size can no longer be negative
  • Reorder appearance options

PR Checklist

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jan 13, 2021
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the thing below. Please fix before you merge.

src/cascadia/TerminalSettingsEditor/Launch.xaml Outdated Show resolved Hide resolved
@DHowett DHowett changed the title Global settings polish Polish Global settings a bit Jan 14, 2021
@DHowett
Copy link
Member

DHowett commented Jan 14, 2021

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 14 Jan 2021 01:33:19 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit f8ccf64 into main Jan 14, 2021
@ghost ghost deleted the dev/pabhoj/global_polish branch January 14, 2021 01:34
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
Polish for global settings in SUI

- Launch size can no longer be negative
- Reorder appearance options

## PR Checklist
* [x] Closes microsoft#8766
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish Settings UI: Global Settings polish
4 participants