Initialize the foreground and background in TermControl's constructor #9792
Conversation
| // (they will also be called later in UpdateAppearance, but we want to have it here so | ||
| // that the terminal is not gray on startup) | ||
| const auto bg = _settings.DefaultBackground(); | ||
| _BackgroundColorChanged(bg); |
There was a problem hiding this comment.
I'm actually.. afraid of this. BackgroundColorChanged is also a fire_and_forget which we should not use from the constructor (!)
There was a problem hiding this comment.
Ah, thanks for pointing that out. Fixed it here and in _UpdateAppearanceFromUIThreadUnderLock
DHowett
added
the
zPreview-Service-Queued-1.13
| @@ -198,8 +198,16 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| // Set the foreground and background here in the constructor | |||
| // (they will also be called later in UpdateAppearance, but we want to have it here so | |||
| // that the terminal is not gray on startup) | |||
| const auto bg = _settings.DefaultBackground(); | |||
| _BackgroundColorChanged(bg); | |||
| til::color newBgColor{ _settings.DefaultBackground() }; | |||
There was a problem hiding this comment.
i suspect you know what i am going to say about us having three copies of this code ;P
There was a problem hiding this comment.
ahh haha alright that's fair... I was just trying to have it so there's only 1 update appearance call but okay will make a helper for the fg/bg
|
We're going to ship w/the gray flash. I'll keep this marked for Servicing. |
zadjii-msft
added
the
Area-TerminalControl
|
Wow, this is still relevant @zadjii-msft with your split? |
|
I cannot repro the 'starting up gray' issue so I'm closing this! |
DHowett
removed
the
zPreview-Service-Queued-1.13
We recently moved setting the foreground and background out of
TermControl::_ApplyUISettings, but that means we no longer set theforeground/background in the constructor, resulting in the terminal
being gray on startup until we call
UpdateAppearanceafter therenderer is setup. This change sets the foreground and background in the
TermControl constructor to avoid this.
Validation Steps Performed
Terminal no longer starts up gray