Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Python 3.7 deps in separate files, use rasterio/fiona Windows wheels #647

Merged
merged 8 commits into from
Jul 4, 2022

Conversation

adamjstewart
Copy link
Collaborator

Rasterio and fiona both have Windows wheels now. The only time we need to use conda in CI is to install rasterio on Windows for Python 3.7 which is no longer supported. Once we drop Python 3.7 support (about 12 months from now) conda will no longer be needed in CI.

This PR also stores all dependencies that require a different version for Python 3.7 in separate files. This prevents dependabot from updating them and reporting security vulnerabilities. These files will need to be updated once the numpy ecosystem drops Python 3.8 support.

@github-actions github-actions bot added the testing Continuous integration testing label Jul 2, 2022
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Jul 2, 2022
@adamjstewart adamjstewart dismissed a stale review via 093219c July 2, 2022 23:18
@adamjstewart adamjstewart merged commit 79144be into main Jul 4, 2022
@adamjstewart adamjstewart deleted the deps/separate-reqs branch July 4, 2022 06:21
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
…heels (microsoft#647)

* Store Python 3.7 deps in separate files, use rasterio/fiona Windows wheels

* Fix fiona 1.9 warning

* Fix import error

* Try again

* Expand obj kwargs

* Fiona still support Python 3.7

* Investigate segfaults

* Undo last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant