Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid label from interface member #162

Merged
merged 1 commit into from
May 13, 2019
Merged

Remove invalid label from interface member #162

merged 1 commit into from
May 13, 2019

Conversation

Gerrit0
Copy link
Contributor

@Gerrit0 Gerrit0 commented May 13, 2019

I can't run Rush as instructed due to my environment (Node & Python are both to new), but as far as I can tell the effected file isn't used anywhere, so nothing should be changed.

Ref: #9 (comment)

@octogonz
Copy link
Collaborator

I can't run Rush as instructed due to my environment (Node & Python are both to new), but as far as I can tell the effected file isn't used anywhere,

Agreed.

octogonz
octogonz approved these changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@octogonz octogonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@octogonz octogonz merged commit 2951a50 into microsoft:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octogonz octogonz octogonz approved these changes

@iclanton iclanton Awaiting requested review from iclanton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gerrit0 @octogonz