Refactor MethodProvider
#3756
Merged
Refactor MethodProvider
#3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
m-nash
reviewed
Jul 8, 2024
...http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/ConstructorProvider.cs
Outdated
Show resolved
Hide resolved
m-nash
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3739
Previously, constructors and methods are both represented by
MethodProvider, which is quite inconvenience in some cases that we want to get theReturnTypeout from a method, we will have to cast theSignaturetoMethodSignature.A new type
ConstructorProvideris introduced in this PR to represent ctors only and now theSignaturetype isMethodSignatureinMethodProviderwhich only represents the normal methods.Considering that ctors and methods are similar, we may add a common base type to
MethodProviderandConstructorProvider, such asMethodBaseProviderjust like howMethodSignatureandConstructorSignaturedo.But currently I did not see any use case that requires to add ctors and methods into the same list, therefore this PR does not add that, and we could always add that part later.