Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openimageio] Upgrade version, add features and fix build failure #8543

Merged
merged 14 commits into from
Feb 9, 2020
Merged

[openimageio] Upgrade version, add features and fix build failure #8543

merged 14 commits into from
Feb 9, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 10, 2019 •
edited
Loading

  • Upgrade to 2.1.9.0.
  • Delete expired options.
  • Fix build failure in Visual Studio 2019.
  • Fix static build.
  • Add features:
  1. ffmpeg
  2. field3d
  3. freetype
  4. opencv
  5. gif
  6. openjpeg
  7. webp

Related: #8416 #9594.

Note: all features test pass with following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Oct 10, 2019
@JackBoosY JackBoosY mentioned this pull request Oct 11, 2019
Closed
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

/azp run

1 similar comment
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY mentioned this pull request Dec 25, 2019
Closed
@JackBoosY JackBoosY marked this pull request as ready for review December 25, 2019 06:17
@JackBoosY JackBoosY changed the title [openimageio]Upgrade version and add features. [openimageio] Upgrade version and add features. Dec 25, 2019
@JackBoosY JackBoosY changed the title [openimageio] Upgrade version and add features. [openimageio] Upgrade version and add features Dec 25, 2019
[openimageio] Remove feature ptex due to some link error. Fix depende…
88727b4 
…ncies opencv and webp. Merge fix dependency patches.
@JackBoosY JackBoosY changed the title [openimageio] Upgrade version and add features [openimageio] Upgrade version, add features and fix build failure in Visual Studio 2019 Dec 26, 2019
@JackBoosY JackBoosY changed the title [openimageio] Upgrade version, add features and fix build failure in Visual Studio 2019 [openimageio] Upgrade version, add features and fix build failure Dec 26, 2019
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY mentioned this pull request Jan 9, 2020
Closed
@JackBoosY
Copy link
Contributor Author

/azp run

@PhoebeHui PhoebeHui self-assigned this Jan 14, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 16, 2020
This was referenced Jan 19, 2020
Closed
Closed
theblackunknown
theblackunknown reviewed Jan 19, 2020
View reviewed changes
Copy link
Contributor

@theblackunknown theblackunknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this my PR of yours I have added comment for the difference between them
Let me know what you think

I'll checkout your PR and check if my scenarios also work with yours

ports/openimageio/CONTROL Show resolved Hide resolved
ports/openimageio/CONTROL Outdated Show resolved Hide resolved
ports/openimageio/portfile.cmake Show resolved Hide resolved
ports/openimageio/portfile.cmake Show resolved Hide resolved
@theblackunknown theblackunknown mentioned this pull request Jan 19, 2020
Closed
@theblackunknown
Copy link
Contributor

I have just tested your PR and it works nice on my machine with the exceptions of the tools feature with a triplet requested dynamic linkage on Windows because the tools cannot find required dll

So I would suggest to :

  1. Modify the portfile to have tools to installed into ${CURRENT_PACKAGES_DIR}/tools/${PORT}
  2. Modify the portfile to call vcpkg_copy_tool_dependencies("${CURRENT_PACKAGES_DIR}/tools/${PORT}") after cmake install and fixup are done

@JackBoosY
Copy link
Contributor Author

@theblackunknown Fixed.

This was referenced Jan 26, 2020
Closed
Closed
@DerZade
Copy link

DerZade commented Feb 3, 2020

Any update on this?

@JackBoosY
Copy link
Contributor Author

@ras0219-msft Ready to merge this PR now, some PR are waiting for the merger of this PR.

@ras0219-msft ras0219-msft merged commit b20c6d3 into microsoft:master Feb 9, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

@JackBoosY JackBoosY deleted the dev/jack/8416 branch February 10, 2020 02:35
@JackBoosY JackBoosY mentioned this pull request Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theblackunknown theblackunknown theblackunknown approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@PhoebeHui PhoebeHui

@NancyLi1013 NancyLi1013

@dan-shaw dan-shaw

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JackBoosY @theblackunknown @DerZade @ras0219-msft @PhoebeHui @NancyLi1013 @dan-shaw