Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL input and output binding verified templates #3700

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VasuBhog
Copy link
Contributor

@VasuBhog VasuBhog commented Jun 7, 2023

Adding SQL input and output bindings to the verified templates list as we have now GA'd.

We support
C#, C#-Script (no template), Javascript, Typescript, Python, PowerShell, and Java.

@VasuBhog VasuBhog requested a review from a team as a code owner June 7, 2023 22:25
@@ -33,6 +35,6 @@ export function getDotnetVerifiedTemplateIds(version: string): RegExp[] {
}

return verifiedTemplateIds.map(id => {
return new RegExp(`^azure\\.function\\.csharp\\.(?:isolated\\.|)${id}\\.[0-9]+\\.x$`, 'i');
return new RegExp(`^azure\\.function\\.csharp\\.(?:isolated\\.|)${id}(\\.[0-9]+\\.x|)$`, 'i');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussions with @alexweininger and @nturinski, we found that this regex specifically only looks for template identity names that include .x.Version.x alongside it to be included for the verified templates list. However, after looking over the templates.json of many extensions we found most include either .1.x or .2.x and it came to our assumption that this was the function runtimes to keep track of what is supported. However, since this seems like an extremely tedious task, it was forgotten and no longer updated for many extensions as such.

As such, I would like to know if we could change the regex to not include the versioning requirement in order for GA'd SQL input/output binding can be shown on the verified lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants