add pinned cmake commands view #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyo1997
requested review from
snehara99,
gcampbell-msft,
lukka and
benmcmorran
…into dev/mookerem/pin-cmd-pallete
…pinned list in UI
snehara99
previously approved these changes
Jan 19, 2024
|
Nbd, but for UI changes it would be easier to review if you add a screenshot |
gcampbell-msft
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Overall, the changes of implementation look good and I've tested the feature and it seems pretty cool and works well! Just some code and design changes I'd like to see if possible before merging.
One other thing, when you test, when you open VS Code for the first time, does the Pinned Commands welcome view appear within the same CMake Activity bar view with the Project Status and the Project Outline? If not, I think that it should.
Great job 👍
|
Also, there seem to be some build failures that may be due to flaky issues with the windows test, but I requeued to try again. |
…rosoft/vscode-cmake-tools into dev/mookerem/pin-cmd-pallete
…into dev/mookerem/pin-cmd-pallete
gcampbell-msft
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #3296
This changes adds a new view in sidebar where users can add cmake commands to pin