Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tooltip shows "loading..." when hovering the mouse over "Image group" #2679

Closed
v-ruizh opened this issue Jan 28, 2021 · 4 comments · Fixed by #2685 or #2697
Closed

The tooltip shows "loading..." when hovering the mouse over "Image group" #2679

v-ruizh opened this issue Jan 28, 2021 · 4 comments · Fixed by #2685 or #2697
Milestone

Comments

@v-ruizh
Copy link

v-ruizh commented Jan 28, 2021

OS: Win 10
Build Version: 20210127.15

Repro Steps:

  1. Navigate to Docker view.
  2. Hover the mouse over "Image group", check the tooltip.

Expect:
The tooltip shows well, such as when hovering the mouse over the image.
image

Actual:
The tooltip shows "loading...".
image

More Info:

  1. This issue does not reproduce when hovering the mouse over the image/container.
  2. This issue also reproduces when hovering the mouse over "Container group/Azure/Docker Hub...".
@bwateratmsft
Copy link
Contributor

I'm trying on Windows as well and it's not showing any tooltip at all for the group nodes, which is what I'd expect. @v-ruizh does this happen consistently?

@bwateratmsft bwateratmsft added this to the 1.10.0 milestone Jan 28, 2021
@bwateratmsft
Copy link
Contributor

Ok, I can repro this issue on Insiders. I'll take a look.

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Jan 28, 2021

@alexr00 I saw you have some changes in this area; is there a difference between 1.52.1 and the latest Insiders that would result in "Loading..." being shown for providers that do implement resolveTreeItem but leave tooltip equal to the prior value? The code for that is here:
https://github.com/microsoft/vscode-azuretools/blob/main/ui/src/tree/AzExtTreeDataProvider.ts#L61-L67

If the concrete tree item object implements resolveTooltip, then we call it for the tooltip, otherwise return the tree item unchanged.

EDIT:

Aha, yes! microsoft/vscode#111615 / microsoft/vscode@5162c8e

Is there a way to stop it from showing "Loading..." for things that won't ever change?

@bwateratmsft
Copy link
Contributor

Working on an upstream fix in vscode-azureextensionui, but also opening microsoft/vscode#115337. Either of those two will fix our issue.

@bwateratmsft bwateratmsft removed their assignment Jan 29, 2021
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants