Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If tooltip is falsy after resolveTreeItem is called, then the tooltip gets stuck as 'Loading...' #115337

Closed
bwateratmsft opened this issue Jan 28, 2021 · 3 comments
Closed

If tooltip is falsy after resolveTreeItem is called, then the tooltip gets stuck as 'Loading...' #115337

bwateratmsft opened this issue Jan 28, 2021 · 3 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues verified Verification succeeded
Milestone
January 2021

Comments

@bwateratmsft
Copy link
Contributor

Issue Type: Bug

In the past, if the tree item tooltip was falsy, the label would be used instead on hover.

This code makes it so that if the tree item's tooltip is falsy after calling resolveTreeItem, then instead of following the old behavior and using label, it will stick as 'Loading...' forever.

Instead, if resolvedTooltip is falsy, it should fall back to label to most closely resemble prior behavior.

VS Code version: Code - Insiders 1.53.0-insider (7b0cfdd, 2021-01-27T08:59:32.031Z)
OS version: Windows_NT x64 10.0.19042

System Info
Item Value
CPUs Intel(R) Xeon(R) CPU E5-1620 v3 @ 3.50GHz (8 x 3492)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.91GB (16.38GB free)
Process Argv --crash-reporter-id edba2bce-ac1c-499b-b3ff-28d400cc9143
Screen Reader no
VM 0%
Extensions (11)
Extension Author (truncated) Version
vscode-eslint dba 2.1.14
vscode-docker ms- 1.9.1
csharp ms- 1.23.8
python ms- 2021.1.502429796
jupyter ms- 2020.12.414227025
remote-containers ms- 0.156.0
remote-ssh ms- 0.63.0
remote-ssh-edit ms- 0.63.0
remote-wsl ms- 0.53.2
vscode-remote-extensionpack ms- 0.20.0
azure-account ms- 0.9.5
A/B Experiments 
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt600:30247031
@bwateratmsft
Copy link
Contributor Author

@alexr00 FYI

This was referenced Jan 28, 2021
Closed
Merged
Closed
@alexr00 alexr00 added this to the January 2021 milestone Feb 1, 2021
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues candidate Issue identified as probable candidate for fixing in the next release labels Feb 1, 2021
alexr00 added a commit that referenced this issue Feb 1, 2021
@alexr00
Use label as tooltip fallback properly
b24036e 
Part of #115337
alexr00 added a commit that referenced this issue Feb 1, 2021
@alexr00
Use label as tooltip fallback properly
3b38307 
Part of #115337
@alexr00 alexr00 mentioned this issue Feb 1, 2021
Merged
alexr00 added a commit that referenced this issue Feb 1, 2021
@alexr00
Use label as tooltip fallback properly (#115537)
565dc97 
Fixes #115337
@alexr00 alexr00 closed this as completed Feb 1, 2021
@bwateratmsft bwateratmsft mentioned this issue Feb 1, 2021
Merged
sbatten pushed a commit that referenced this issue Feb 1, 2021
@alexr00 @sbatten
Use label as tooltip fallback properly
2d5a258 
Part of #115337
@sbatten
Copy link
Member

sbatten commented Feb 1, 2021

@bwateratmsft this fix is out in the latest insiders, can you please let us know when you've verified, thanks

@bwateratmsft
Copy link
Contributor Author

@sbatten @alexr00 everything seems to be working nicely, thanks!

@sbatten sbatten added the verified Verification succeeded label Feb 2, 2021
plainerman pushed a commit to plainerman/vscode that referenced this issue Feb 2, 2021
@alexr00 @plainerman
Use label as tooltip fallback properly
62a163e 
Part of microsoft#115337
MarcoZehe pushed a commit to MarcoZehe/vscode that referenced this issue Feb 3, 2021
@alexr00 @MarcoZehe
Use label as tooltip fallback properly
194e56c 
Part of microsoft#115337
sbatten added a commit that referenced this issue Feb 6, 2021
@sbatten @lszomoru
@isidorn @alexr00 @alexdima @jrieken @CameronIrvine @bpasero
Trusted Workspaces Feature Branch Merge (#115961)
afd102c 
* draft trusted workspace service / model

* renaming

* add request model and action

* err fix

* add request handlers with mock actions

* some quick fixes

* adding badge icon to activity bar gear

* Add Statusbar item to indicate trust

* Cleanup code

* Add background color

* Use theme color for the status background color

* adding basic editing experience

* observe trust with startup tasks

* Extension enablement

* Add capability to provide a custom message

* Remove old actions

* explorer: if you can not undo, pass undo to editor

fixes #111630

* Remove plug icon from ports view
Part of microsoft/vscode-internalbacklog#1689

* Fixed compilation error

* Handle extension uninstall

* Handle extension install

* Ability to prompt when state is untrusted

* Do not change state is the modal dialog is dismissed or the Cancel button is pressed

* Refactored enablement code

* Prompt when installing from VSIX

* Prompt when installing from the Gallery

* Move file into the browser folder

* fixes and polish

* restructure workspace contributions

* restructure actions and use confirmations

* Initial draft of the proposed APIs

* Added stubs for the proposed api

* Trusted Workspace proposed API

* Fix a regression introduced by merge

* status bar indicator improvements

* remove helper command as we now have hooks

* verbose messaging for the immediate request

* add indication to global activity icon of pending request

* try personal title

* Add configuration setting

* Add additional extension actions

* Fix contributions

* Removed context key that is not needed

* Fixed issue with the dialog

* Reduce arbitrary event limiter from 16ms down to 4.16666 (support for monitors up-to 240hz) #107016

* Fixes #115221: update emoji tests

* Give a higher priority to language configuration set via API call (#114684)

* debug console menu action polish

* Avoid the CSS general sibling combinator ~ for perf reasons

* more notebook todos

* Use label as tooltip fallback properly
Part of #115337

* Fixes microsoft/monaco-editor#2329: Move `registerThemingParticipant` call to `/editor/`

* Fix port label not always getting set
Part of microsoft/vscode-remote-release#4364

* simplify map creation, fyi @bpasero

* Fix #114432: Multiple save dialogs appearing on Windows if Ctrl+S is pressed multiple times (#114450)

* fix multiple save dialogs appearing on Windows when spamming Ctrl+S

* remove old fix and instead keep track of windows with open dialogs in the dialogMainService

* keep initialisation of activeWindowDialogs in constructor

* remove unused variable

* some changes

* queue dialogs based on hash of options

* simplify structure, fix comment typo

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* remove unnecessary async/await for aquireFileDialogLock method

* don't acquire file dialog lock for message boxes

* use MessageBoxReturnValue | SaveDialogReturnValue | OpenDialogReturnValue instead of any type for getWindowDialogQueue

* Apply suggestions from code review

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>

* 💄 dialog main service locks

* debt - adopt some ? operator

* Better hiding of custom hover in icon label

* Limit to 8ms (120fps)

* more API todos for notebooks

* 💄

* Update grammars

* chore - group notebook specific api proposals together

* added unreleased fixes to endgame notebook

* Add changes back to the modal dialog

* Add back the workspace trust proposed APIs

* Adjust dialog buttons

* Standardize on WorkspaceTrust name across interfaces, classes, variables

* Renamed some of the missing keys

* Add TestWorkspaceTrust stub and fix failing tests

* Add requiresWorkspaceTrust property to fix test failure

* remove notebook change

Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: isidor <inikolic@microsoft.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: TacticalDan <gorksorf@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com>
Co-authored-by: Cameron <cameron532@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
3 participants
@sbatten @bwateratmsft @alexr00