Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the language server to 0.13.0 #4343

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Jul 22, 2024

This update includes a small linting fix as well as highlighting support for heredocs. You can use the file below to test the changes.

  1. The :- syntax provides a default so we should not be flagging the FROM as an error (see Evaluate variable default values in determining if blank rcjsuen/dockerfile-language-server#269).
  2. The language server now provides proper support for the start and end of a heredoc by highlighting the two ends and allowing you to jump from the end of the document to the original definition at the top.
# the FROM line should no longer be flagged as an error
FROM ${VAR:-alpine}

# 1. clicking on "file" on lines 6 or 8 should highlight the two occurrences
# 2. you can now use "Go to Definition" on line 8 to jump to line 6
RUN echo <<file
abc
file

This update includes a small linting fix as well as highlighting support
for heredocs.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen rcjsuen requested a review from a team as a code owner July 22, 2024 11:16
@rcjsuen rcjsuen mentioned this pull request Jul 26, 2024
@bwateratmsft bwateratmsft merged commit 3258de1 into microsoft:main Jul 26, 2024
2 checks passed
@rcjsuen rcjsuen deleted the update-lsp-0.1.30 branch July 26, 2024 20:20
@microsoft microsoft locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants