Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change approach to starting the Gradle Server and fix dist download progress #540

Merged
merged 15 commits into from
Jul 25, 2020

Conversation

badsyntax
Copy link
Collaborator

@badsyntax badsyntax commented Jun 24, 2020

Fixes #512
Fixes #536

Changes

  • Gradle dist progress is now reported and is cancellable
  • Start server in background using node APIs. Server terminal is no longer displayed
  • Server logs are displayed in the "Gradle Tasks" output channel
  • Better (graceful) server restart logic (cancel all builds before gracefully killing the server with SIGTERM)
  • Update README
  • Due to change in how the server is started, this could be a breaking change for users who might have set ENV vars in terminal.integrated.env.* - Not sure what to do about this...

Screenshots:

Server start, and showing gradle dist download progress:

Screenshot 2020-06-24 at 15 04 11

Server killed (with killall java from outside vscode):

Screenshot 2020-06-24 at 15 04 58

Server exception (nullpointer) shown in the output channel:

Screenshot 2020-06-24 at 16 54 46

Improved error messaging in task terminals when server exceptions occur:

Screenshot 2020-06-24 at 16 54 54

TODO:

  • Update README for troubleshooting instructions for ENV/PATH issues
  • Add screenshot that shows what an uncaught exception looks like (with a long stacktrace)

extension/src/server/GradleServer.ts Outdated Show resolved Hide resolved
extension/src/extension/Extension.ts Outdated Show resolved Hide resolved
@badsyntax
Copy link
Collaborator Author

Remove server task definition from package.json

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 2 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_262) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@badsyntax badsyntax merged commit f1e61bd into master Jul 25, 2020
@badsyntax badsyntax deleted the hide-server-terminal branch July 25, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Output tab for Task - Gradle Server Allow user to see gradle dist download progress
1 participant