Export to html/pdf/python on Web when connected to remote server #10069
Conversation
| @injectable() | ||
| export class ExportToPDF implements INbConvertExport { |
There was a problem hiding this comment.
It looks like all of your renames are not be detecting as renames? I usually force this with git add -A but not sure if you can do it after the fact.
There was a problem hiding this comment.
didn't know I could do that, will try with next rename 💪
| @inject(IExportDialog) protected readonly filePicker: IExportDialog, | ||
| @inject(ExportUtil) protected readonly exportUtil: ExportUtil, | ||
| @inject(INotebookImporter) protected readonly importer: INotebookImporter, | ||
| @inject(ExportInterpreterFinder) private exportInterpreterFinder: ExportInterpreterFinder | ||
| ) {} | ||
|
|
||
| public async export( |
There was a problem hiding this comment.
is this method needed in these classes?
There was a problem hiding this comment.
I still put it there since we register it as serviceManager.addSingleton<INbConvertExport>(INbConvertExport, ExportBase, 'Export Base');, not sure why it's needed there. I can send a pr later to have it fixed.
| import { ReportableAction } from '../progress/types'; | ||
|
|
||
| @injectable() | ||
| export class ExportBase implements INbConvertExport, IExportBase { |
There was a problem hiding this comment.
ExportHelper or Exporter is probably a better name now since they aren't being extended anymore since Base usually implies that it is a parent class
Codecov Report
@@ Coverage Diff @@
## main #10069 +/- ##
======================================
- Coverage 64% 64% -1%
======================================
Files 216 216
Lines 10060 10095 +35
Branches 1613 1618 +5
======================================
+ Hits 6508 6527 +19
- Misses 3028 3038 +10
- Partials 524 530 +6
|
Fixes #9996
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).This PR covers following changes:
src/platform/progress/decorator.tsandsrc/platform/progress/progressReporter.tsare now common modules (nonodeapi usage)exportToHTML,exportToPython,exportToPdf,exportToPythonPlainare common modulesexportBasehas two variations,exportBase.nodeandexportBase.web. Their major differences are:exportBase.webdoesn't create temp filesnbconvertexportBase.noderunnbconvertin local processexportBase.webrunnbconvertthrough silent cell execution. It fetches the content throughcontentsManagerand save to workspace fs.fileConverteras the common module contains most logics of how we export files, with some exceptions innodeenv, which are overridden infileConverter.node