-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve code lens provider performance #11696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was probably not introduced in this PR but the check for text document uris seem wrong. |
rebornix
reviewed
Oct 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #11696 +/- ##
======================================
Coverage 59% 60%
======================================
Files 483 483
Lines 34447 34498 +51
Branches 5601 5609 +8
======================================
+ Hits 20668 20703 +35
- Misses 11827 11841 +14
- Partials 1952 1954 +2
|
rebornix
requested changes
Oct 19, 2022
src/interactive-window/editor-integration/codelensProviderActivator.ts
Outdated
Show resolved
Hide resolved
amunger
force-pushed
the
aamunger/codeLensPerf
branch
from
October 20, 2022 17:46
752c6f7
to
be41496
Compare
rebornix
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #11433
When looking at a large file with many code lenses, most of the code lens provider's is spent creating the code lens objects that are returned, and resulting gc calls. Even more is spent serializing those objects for the response, but that is outside the extension's scope.
This change focuses on speeding up the iteration through code lens range, reducing the
getDocument
andlocalize
calls.Parsing the file itself to divide it into cells isn't that large of an impact, so I didn't spend the time implementing a more complex incremental update.