Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ServerConnectionType. #11913

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Remove ServerConnectionType. #11913

merged 1 commit into from
Nov 4, 2022

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Nov 4, 2022 •
edited
Loading

Debt: first step of supporting multi jupyter servers gracefully.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix mentioned this pull request Nov 4, 2022
Closed
54 tasks
@rebornix rebornix marked this pull request as ready for review November 4, 2022 17:23
@rebornix rebornix merged commit ea5674c into main Nov 4, 2022
@rebornix rebornix deleted the rebornix/favourite-deer branch November 4, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebornix @TylerLeonhardt