Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Kernel Specs & Python envs in kernel pick #11926

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Nov 6, 2022

Fixes #11927
Part of #11904

Recording 2022-11-07 at 09 35 56

@DonJayamanne DonJayamanne mentioned this pull request Nov 6, 2022
54 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #11926 (aa4844d) into main (3c58033) will increase coverage by 0%.
The diff coverage is 77%.

❗ Current head aa4844d differs from pull request most recent head 498cd63. Consider uploading reports for the commit 498cd63 to get more accurate results

@@           Coverage Diff           @@
##            main   #11926    +/-   ##
=======================================
  Coverage     62%      62%            
=======================================
  Files        490      491     +1     
  Lines      34602    34702   +100     
  Branches    5616     5624     +8     
=======================================
+ Hits       21691    21781    +90     
- Misses     10831    10837     +6     
- Partials    2080     2084     +4     
Impacted Files Coverage Δ
src/kernels/raw/types.ts 100% <ø> (ø)
...llers/kernelSource/notebookKernelSourceSelector.ts 10% <40%> (+<1%) ⬆️
src/platform/common/utils/localize.ts 75% <71%> (-1%) ⬇️
...raw/finder/contributedLocalPythonEnvFinder.node.ts 76% <76%> (ø)
src/kernels/internalTypes.ts 100% <100%> (ø)
...aw/finder/contributedLocalKernelSpecFinder.node.ts 75% <100%> (ø)
src/kernels/serviceRegistry.node.ts 100% <100%> (ø)
src/platform/common/process/condaService.node.ts 67% <0%> (-2%) ⬇️
...c/platform/common/process/pythonDaemonPool.node.ts 78% <0%> (-1%) ⬇️
...c/kernels/execution/cellExecutionMessageHandler.ts 77% <0%> (-1%) ⬇️
... and 11 more

@rebornix rebornix merged commit d561d93 into main Nov 7, 2022
@rebornix rebornix deleted the issue11904SeparateKernels branch November 7, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate item for Kernel Specs vs Python Environments
4 participants