Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow Make a suggestion button press if already have a suggestion in the comment #6195

Closed
joaomoreno opened this issue Aug 30, 2024 · 1 comment · Fixed by #6202
Closed

Disallow Make a suggestion button press if already have a suggestion in the comment #6195

joaomoreno opened this issue Aug 30, 2024 · 1 comment · Fixed by #6202
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug polish verified Verification succeeded
Milestone
September 2024

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Aug 30, 2024 •
edited
Loading

I often hit this situation

  1. Start a PR comment
  2. Press Make a suggestion
  3. Type the suggestion
  4. Get confused and think that the Make a suggestion button will submit the suggestion. Press it. Retract in shame.

We should disable this button once a suggestion is in the comment.

Screen.Recording.2024-08-30.at.13.26.05.mov
@alexr00
Copy link
Member

alexr00 commented Aug 30, 2024

Until the comment has been submitted we don't have the contents of the comment in the comment API. We'll need to watch for if the active editor is a comment editor and check the contents of the editor for a suggestion.

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug polish labels Aug 30, 2024
@alexr00 alexr00 added this to the September 2024 milestone Aug 30, 2024
alexr00 added a commit that referenced this issue Aug 30, 2024
@alexr00
Don't show "make suggestion" when there's already a suggestion in the…
43f501e 
… editor

Fixes #6195
@alexr00 alexr00 mentioned this issue Aug 30, 2024
Merged
alexr00 added a commit that referenced this issue Sep 6, 2024
@alexr00
Don't show "make suggestion" when there's already a suggestion in the…
f685eaf 
… editor (#6202)

Fixes #6195
@rzhao271 rzhao271 added the verified Verification succeeded label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug polish verified Verification succeeded
Projects
None yet
Milestone
September 2024
3 participants
@joaomoreno @rzhao271 @alexr00