Ensure escape on TOML and requirements is treated as cancel. (#20739)

microsoft · Feb 27, 2023 · 35be3c2 · 35be3c2
1 parent 5d9bc1e
commit 35be3c2
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts b/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts
@@ -192,6 +192,10 @@ async function createEnvironment(options?: CreateEnvironmentOptions): Promise<Cr
                 throw ex;
             }
 
+            if (version === undefined) {
+                traceError('Python version was not selected for creating conda environment.');
+                return MultiStepAction.Cancel;
+            }
             return MultiStepAction.Continue;
         },
         undefined,

diff --git a/src/client/pythonEnvironments/creation/provider/venvUtils.ts b/src/client/pythonEnvironments/creation/provider/venvUtils.ts
@@ -151,6 +151,8 @@ export async function pickPackagesToInstall(
                                 });
                             }
                             packages.push({ installType: 'toml', source: tomlPath });
+                        } else {
+                            return MultiStepAction.Cancel;
                         }
                     } catch (ex) {
                         if (ex === MultiStepAction.Back || ex === MultiStepAction.Cancel) {
@@ -192,6 +194,8 @@ export async function pickPackagesToInstall(
                         installList.forEach((i) => {
                             packages.push({ installType: 'requirements', installItem: i });
                         });
+                    } else {
+                        return MultiStepAction.Cancel;
                     }
                 } catch (ex) {
                     if (ex === MultiStepAction.Back || ex === MultiStepAction.Cancel) {

diff --git a/src/test/pythonEnvironments/creation/provider/condaCreationProvider.unit.test.ts b/src/test/pythonEnvironments/creation/provider/condaCreationProvider.unit.test.ts
@@ -76,7 +76,7 @@ suite('Conda Creation provider tests', () => {
         });
         pickPythonVersionStub.resolves(undefined);
 
-        assert.isUndefined(await condaProvider.createEnvironment());
+        await assert.isRejected(condaProvider.createEnvironment());
     });
 
     test('Create conda environment', async () => {

diff --git a/src/test/pythonEnvironments/creation/provider/venvUtils.unit.test.ts b/src/test/pythonEnvironments/creation/provider/venvUtils.unit.test.ts
@@ -80,7 +80,7 @@ suite('Venv Utils test', () => {
             '[project]\nname = "spam"\nversion = "2020.0.0"\n[build-system]\nrequires = ["setuptools ~= 58.0", "cython ~= 0.29.0"]\n[project.optional-dependencies]\ntest = ["pytest"]\ndoc = ["sphinx", "furo"]',
         );
 
-        showQuickPickWithBackStub.rejects(windowApis.MultiStepAction.Cancel);
+        showQuickPickWithBackStub.resolves(undefined);
 
         await assert.isRejected(pickPackagesToInstall(workspace1));
         assert.isTrue(
@@ -215,7 +215,7 @@ suite('Venv Utils test', () => {
             return Promise.resolve([]);
         });
 
-        showQuickPickWithBackStub.rejects(windowApis.MultiStepAction.Cancel);
+        showQuickPickWithBackStub.resolves(undefined);
 
         await assert.isRejected(pickPackagesToInstall(workspace1));
         assert.isTrue(