Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the dev container over to an MCR image #21591

Closed
anthonykim1 opened this issue Jul 8, 2023 · 1 comment
Closed

Move the dev container over to an MCR image #21591

anthonykim1 opened this issue Jul 8, 2023 · 1 comment
Assignees
@anthonykim1
Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2023

Comments

@anthonykim1
Copy link

anthonykim1 commented Jul 8, 2023 •
edited
Loading

Move the dev container over to an MCR image. Switch from Fedora to Microsoft official image to adhere to company policy.

Be able to run "source /workspaces/vscode-python/.venv/bin/activate" to activate the pre-built virtual environment!

Should be able to launch instance of codespaces from our repo, go to run and debug on the left panel and RUN unittests, functional tests successfully and pass the tests.

Typing conda in the terminal should also give you options to run bunch of conda commands without error.
There should also be fish terminal option as one of the options next to the plus icon in bottom panel.

Testing: #21675
@anthonykim1 anthonykim1 added the needs PR Ready to be worked on label Jul 8, 2023
@anthonykim1 anthonykim1 self-assigned this Jul 8, 2023
@anthonykim1 anthonykim1 self-assigned this Jul 8, 2023
@kieferrm kieferrm mentioned this issue Jul 9, 2023
Closed
28 tasks
@anthonykim1 anthonykim1 added this to the July 2023 milestone Jul 10, 2023
@anthonykim1 anthonykim1 mentioned this issue Jul 21, 2023
Merged
@karrtikr
Copy link

@anthonykim1 Make sure to add the area and feature request label as well

@anthonykim1 anthonykim1 added the feature-request Request for new features or functionality label Jul 24, 2023
anthonykim1 added a commit that referenced this issue Jul 24, 2023
@anthonykim1
Dev Container Using MCR (#21675)
6af959d 
Dev container rewrite using MCR. 
Pyenv for installing and managing python versions. Fish also installed
as optional (able to view as shell option in codespaces). Also fixing
conda error. Takes care of: #21591 rewrite from: #21435 to adhere to
company policy.
@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Jul 24, 2023
@github-actions github-actions bot removed the needs PR Ready to be worked on label Jul 25, 2023
@karrtikr karrtikr added the area-internal Label for non-user facing issues label Jul 25, 2023
@roblourens roblourens added the verified Verification succeeded label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

No branches or pull requests
3 participants
@roblourens @karrtikr @anthonykim1