Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create message when user tries to use smart send with old Python code #22340

Closed
anthonykim1 opened this issue Oct 25, 2023 · 0 comments
Closed

Create message when user tries to use smart send with old Python code #22340

anthonykim1 opened this issue Oct 25, 2023 · 0 comments
Assignees
@anthonykim1
Labels
area-repl on-testplan Added to test plan
Milestone
November 2023

Comments

@anthonykim1
Copy link

Resolves: #22318
Display message/warning/notification when user attempts to run smart send (smart selection and cursor move) on a Python file containing older Python code that will be failed to be picked up by AST module.
@anthonykim1 anthonykim1 added the feature-request Request for new features or functionality label Oct 25, 2023
@anthonykim1 anthonykim1 self-assigned this Oct 25, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 25, 2023
@anthonykim1 anthonykim1 added needs PR Ready to be worked on and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Oct 25, 2023
@anthonykim1 anthonykim1 mentioned this issue Oct 26, 2023
Merged
echarles pushed a commit to datalayer-externals/vscode-python that referenced this issue Nov 20, 2023
@anthonykim1 @cwebster-99
Show warning and allow user to turn off smart send for deprecated Pyt…
3c552f9 
…hon code (microsoft#22353)

Resolves: microsoft#22341 microsoft#22340

Showing warning message after detecting user is on Python file with
deprecated Python code, and are attempting to run smart send via
shift+enter action. Allow user to turn off this via workspace setting.

---------

Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
@anthonykim1 anthonykim1 added this to the November 2023 milestone Nov 27, 2023
@github-actions github-actions bot removed the needs PR Ready to be worked on label Nov 27, 2023
@anthonykim1 anthonykim1 mentioned this issue Nov 27, 2023
Closed
3 tasks
@github-actions github-actions bot added the on-testplan Added to test plan label Nov 27, 2023
@anthonykim1 anthonykim1 mentioned this issue Dec 7, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
area-repl on-testplan Added to test plan
Projects
None yet
Milestone
November 2023
Development

No branches or pull requests
1 participant
@anthonykim1