-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update incorrect JSDoc annotations #12101
Conversation
ready for review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! There are a few bits here and there that could be tidied up (left comments), other than that looks good to me.
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
@kimadeline done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanking you on behalf of yourself. LGTM otherwise.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #12101 +/- ##
=========================================
Coverage ? 60.03%
=========================================
Files ? 657
Lines ? 35575
Branches ? 5003
=========================================
Hits ? 21358
Misses ? 13168
Partials ? 1049
Continue to review full report at Codecov.
|
For #12101
Code quality related. This change just updates a few of the JSDoc
@param
annotations for typescript and javascript files that are either incorrect (wrong argument name), missing, or had typos