Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IInterpreterHashProviderFactory to the ioc container #13632

Merged

Conversation

DavidKutu
Copy link

For:
image
From the nightly flake

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu added the no-changelog No news entry required label Aug 27, 2020
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #13632 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13632      +/-   ##
==========================================
- Coverage   59.77%   59.75%   -0.03%     
==========================================
  Files         670      670              
  Lines       37513    37514       +1     
  Branches     5388     5387       -1     
==========================================
- Hits        22423    22416       -7     
- Misses      13924    13929       +5     
- Partials     1166     1169       +3     
Impacted Files Coverage Δ
src/client/interpreter/locators/types.ts 100.00% <100.00%> (ø)
...discovery/locators/services/hashProviderFactory.ts 100.00% <100.00%> (ø)
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-5.89%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccf189...1e3a28b. Read the comment docs.

@DavidKutu DavidKutu merged commit c37c79d into master Aug 27, 2020
@DavidKutu DavidKutu deleted the david/NoMatchingBindingForIInterpreterHashProviderFactory branch August 27, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants