Added setting to control when interpreter information is displayed in the status bar #19513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 21, 2022 11:52
karrtikr
force-pushed
the
interpreterinofsetting
branch
from
a968e23
to
f97a242
Compare
added 3 commits
July 21, 2022 14:30
karrtikr
commented
Jul 21, 2022
| @@ -18,6 +18,11 @@ export class ConfigurationService implements IConfigurationService { | |||
| this.workspaceService = this.serviceContainer.get<IWorkspaceService>(IWorkspaceService); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line class-methods-use-this | |||
| public get onDidChange(): Event<ConfigurationChangeEvent | undefined> { | |||
There was a problem hiding this comment.
Config service also updates itself on workspace config change, but often workspace config change event (obtained via WorkspaceService) fires before config service updates. So add a separate reliable change event for config service.
karrtikr
added
the
skip package*.json
karthiknadig
approved these changes
Jul 22, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
… the status bar (microsoft/vscode-python#19513) * Added setting to control when interpreter information is displayed in the status bar * Oops * Team reviews * Add feature * Debounce change notification * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19089