Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited Discovery Logic #20631

Merged
merged 86 commits into from
Apr 17, 2023
Merged

Edited Discovery Logic #20631

merged 86 commits into from
Apr 17, 2023

Commits on Apr 6, 2023

  1. switch to using tcp for comm with server

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    d6d24ab View commit details
    Browse the repository at this point in the history

  2. mock test changes

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f2a189a View commit details
    Browse the repository at this point in the history

  3. fix msgs

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9f00e97 View commit details
    Browse the repository at this point in the history

  4. discovery code

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    dff2cac View commit details
    Browse the repository at this point in the history

  5. black formatting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    45faa4f View commit details
    Browse the repository at this point in the history

  6. still working and comments in progress

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    23919f4 View commit details
    Browse the repository at this point in the history

  7. changing to different typing

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    cf0a76d View commit details
    Browse the repository at this point in the history

  8. adding docstrings

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    6e8a87f View commit details
    Browse the repository at this point in the history

  9. fix path and docstring

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    437df9e View commit details
    Browse the repository at this point in the history

  10. black formatting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    38adb97 View commit details
    Browse the repository at this point in the history

  11. functioning test infrastructure 

    Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    65404ee View commit details
    Browse the repository at this point in the history

  12. switch to single expected output file

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    70c123a View commit details
    Browse the repository at this point in the history

  13. try for unittests

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7a20aab View commit details
    Browse the repository at this point in the history

  14. refactoring and adding more .data files

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7f1ebfe View commit details
    Browse the repository at this point in the history

  15. double and dual tests

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    6c2acf7 View commit details
    Browse the repository at this point in the history

  16. cleanup

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    aa9eb74 View commit details
    Browse the repository at this point in the history

  17. fix expected output for unittest folders

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    bdc05d4 View commit details
    Browse the repository at this point in the history

  18. inital take on error handling

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    61ffee9 View commit details
    Browse the repository at this point in the history

  19. switch to correct path to string

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    16baaea View commit details
    Browse the repository at this point in the history

  20. parametrize

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    eb51f15 View commit details
    Browse the repository at this point in the history

  21. remove unneeded comments

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c69bd61 View commit details
    Browse the repository at this point in the history

  22. comments

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c2ffbc9 View commit details
    Browse the repository at this point in the history

  23. fix formatting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    25d0392 View commit details
    Browse the repository at this point in the history

  24. parametrize the tests

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    456f185 View commit details
    Browse the repository at this point in the history

  25. add commenting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    bb2424a View commit details
    Browse the repository at this point in the history

  26. fixing paths for non local testing

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4212119 View commit details
    Browse the repository at this point in the history

  27. unneeded files

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    632ac36 View commit details
    Browse the repository at this point in the history

  28. attempt on http server/client

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    40abfd2 View commit details
    Browse the repository at this point in the history

  29. reverting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4cd75e8 View commit details
    Browse the repository at this point in the history

  30. add commenting, tests are passing

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    108f7e1 View commit details
    Browse the repository at this point in the history

  31. fix paths to ensure all use const

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    616f9b5 View commit details
    Browse the repository at this point in the history

  32. remove local references

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    ba45341 View commit details
    Browse the repository at this point in the history

  33. fixing typing, add error handling

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9e1cd2f View commit details
    Browse the repository at this point in the history

  34. comments, settings fix

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    a601882 View commit details
    Browse the repository at this point in the history

  35. add doc string

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    13df91d View commit details
    Browse the repository at this point in the history

  36. fix comment

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    340dd52 View commit details
    Browse the repository at this point in the history

  37. fixing formatting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    8abd93e View commit details
    Browse the repository at this point in the history

  38. black formatting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4208ebc View commit details
    Browse the repository at this point in the history

  39. black formatting

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c91677e View commit details
    Browse the repository at this point in the history

  40. remove print

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    819d699 View commit details
    Browse the repository at this point in the history

  41. comment noting line num

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    d91038a View commit details
    Browse the repository at this point in the history

  42. change to txt file

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7406d4a View commit details
    Browse the repository at this point in the history

  43. create find line no function

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    37b8643 View commit details
    Browse the repository at this point in the history

  44. line no cont

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    2bbbab1 View commit details
    Browse the repository at this point in the history

  45. Apply suggestions from code review from Brett 

    Co-authored-by: Brett Cannon <brcan@microsoft.com>
    @eleanorjboyd @brettcannon
    eleanorjboyd and brettcannon committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    cf4b22b View commit details
    Browse the repository at this point in the history

  46. switch to any types to avoid private module

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    205beb8 View commit details
    Browse the repository at this point in the history

  47. current changes- broken with add for UUID

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    0ca0a6f View commit details
    Browse the repository at this point in the history

  48. pytest y, unittest n

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    d94e4e9 View commit details
    Browse the repository at this point in the history

  49. both unit and pytest ts working

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    d21c5bf View commit details
    Browse the repository at this point in the history

  50. current state

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    d99dd6b View commit details
    Browse the repository at this point in the history

  51. remove debug

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    543b35f View commit details
    Browse the repository at this point in the history

  52. add jsonRPCProcessor test

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b3d9186 View commit details
    Browse the repository at this point in the history

  53. round 2 changes

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c3b3d01 View commit details
    Browse the repository at this point in the history

  54. round 3 edits

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4fc031d View commit details
    Browse the repository at this point in the history

  55. fix uneeded edits

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    6aa071b View commit details
    Browse the repository at this point in the history

  56. small fixes

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4badcda View commit details
    Browse the repository at this point in the history

  57. comments and typing

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9c596cc View commit details
    Browse the repository at this point in the history

  58. Fix UUID unittest (#20996) 

    UUID is now handled by the adapter therefore is added to options sent to
the server from the adapter.

Since the UUID is no longer being added by the server, the server tests
should no longer test if the server is correctly handling the UUID. This
logic is now passed to the adapter and therefore tests related to
processing non-existent UUID and UUID not currently active is the
adapters role.
    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    709f5f8 View commit details
    Browse the repository at this point in the history

  59. switch to using tcp for comm with server (#20981) 

    code written by @karthiknadig and @eleanorjboyd, which switches to using TCP as the
communication channel between the test adapter in the extension and the
node server that handles the discovery/running of python tests.
---------

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
    @eleanorjboyd @karthiknadig
    eleanorjboyd and karthiknadig committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f730a75 View commit details
    Browse the repository at this point in the history

  60. mock test changes

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7b38e8b View commit details
    Browse the repository at this point in the history

  61. add jsonRPCProcessor test

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    f720341 View commit details
    Browse the repository at this point in the history

  62. comment out new code

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    0cb6ca0 View commit details
    Browse the repository at this point in the history

  63. removing unneeded edit

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4bc71c3 View commit details
    Browse the repository at this point in the history

  64. last few

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3127183 View commit details
    Browse the repository at this point in the history

  65. remove pytest adapter tests from running rn

    @eleanorjboyd
    eleanorjboyd committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    ffa2073 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. fix pyright

    @eleanorjboyd
    eleanorjboyd committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    e54b09d View commit details
    Browse the repository at this point in the history

  2. pyright

    @eleanorjboyd
    eleanorjboyd committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    9265aa0 View commit details
    Browse the repository at this point in the history

  3. black reformat

    @eleanorjboyd
    eleanorjboyd committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    55ec145 View commit details
    Browse the repository at this point in the history

  4. add lambda

    @eleanorjboyd
    eleanorjboyd committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c47da49 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Merge branch 'main' into python-discovery-code

    @eleanorjboyd
    eleanorjboyd authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    a827e31 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Update .vscode/launch.json 

    Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
    @eleanorjboyd @karthiknadig
    eleanorjboyd and karthiknadig authored Apr 11, 2023
    Configuration menu
    Copy the full SHA
    cad3c32 View commit details
    Browse the repository at this point in the history

  2. updated a few types

    @eleanorjboyd
    eleanorjboyd committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ba4e38f View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Merge branch 'main' into python-discovery-code

    @eleanorjboyd
    eleanorjboyd authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    253010d View commit details
    Browse the repository at this point in the history

  2. fix for CLI

    @eleanorjboyd
    eleanorjboyd committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6d8dd25 View commit details
    Browse the repository at this point in the history

  3. fix env var

    @eleanorjboyd
    eleanorjboyd committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    7ae5a15 View commit details
    Browse the repository at this point in the history

  4. Attempt to fix the connection error issue.

    @karthiknadig
    karthiknadig committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0b344f4 View commit details
    Browse the repository at this point in the history

  5. fix typing.

    @karthiknadig
    karthiknadig committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    53bd9b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Throw error when subprocess run fails.

    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    a525ec3 View commit details
    Browse the repository at this point in the history

  2. Log errors

    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    e05e52e View commit details
    Browse the repository at this point in the history

  3. Try winsock reset

    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    3997752 View commit details
    Browse the repository at this point in the history

  4. Revert "Try winsock reset" 

    This reverts commit 3997752.
    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    62a61c0 View commit details
    Browse the repository at this point in the history

  5. Try with shell execute

    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    548140f View commit details
    Browse the repository at this point in the history

  6. Revert "Try with shell execute" 

    This reverts commit 548140f.
    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    d637af0 View commit details
    Browse the repository at this point in the history

  7. Fix pathing for windows

    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    cf0b921 View commit details
    Browse the repository at this point in the history

  8. Try running all python tests without deps

    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    cd4ddac View commit details
    Browse the repository at this point in the history

  9. Ensure proper env use.

    @karthiknadig
    karthiknadig committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    f7caf06 View commit details
    Browse the repository at this point in the history