Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test suite execution import errors due to path ordering #23099

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

shanesaravia
Copy link

  • This has already been discussed and resolved for tests discovery in this PR
  • I have now run into the same issue for executing the test suite and have applied the same fix in this PR
  • Tested and working

Issue for this current PR

Original Issue
Original PR

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Mar 20, 2024
@eleanorjboyd
Copy link
Member

updated branch and running checks now- sorry for the delay!

Copy link
Member

@eleanorjboyd eleanorjboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@eleanorjboyd eleanorjboyd merged commit 7c04ef2 into microsoft:main Mar 29, 2024
35 checks passed
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
…osoft/vscode-python#23099)

- This has already been discussed and resolved for tests discovery in
this [PR](microsoft/vscode-python#22454)
- I have now run into the same issue for executing the test suite and
have applied the same fix in this PR
- Tested and working

[Issue](microsoft/vscode-python#23098) for
this current PR

[Original
Issue](microsoft/vscode-python#22453)
[Original PR](microsoft/vscode-python#22454)

Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
…osoft/vscode-python#23099)

- This has already been discussed and resolved for tests discovery in
this [PR](microsoft/vscode-python#22454)
- I have now run into the same issue for executing the test suite and
have applied the same fix in this PR
- Tested and working

[Issue](microsoft/vscode-python#23098) for
this current PR

[Original
Issue](microsoft/vscode-python#22453)
[Original PR](microsoft/vscode-python#22454)

Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants