Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL Telemetry for Terminal REPL and Native REPL #23941

Merged
merged 4 commits into from
Aug 13, 2024
Merged

REPL Telemetry for Terminal REPL and Native REPL #23941

merged 4 commits into from
Aug 13, 2024

Conversation

anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Aug 12, 2024 •
edited
Loading

Resolves: #23740

Also organize Telemetry for Terminal REPL vs. Native REPL.
Now we can sort them out with new attribute 'replType' on the REPL Event.

With this PR:

  • (EventName.REPL, { replType: 'Terminal' }) for when people launch Terminal REPL via Command Palette, Manually type Python in terminal (tried to account for all Python cases that will trigger REPL).
  • (EventName.REPL, { replType: 'Native' }) for when people launch Native REPL via Command Palette.

@anthonykim1 anthonykim1 added this to the August 2024 milestone Aug 12, 2024
@anthonykim1 anthonykim1 added area-repl area-terminal feature-request Request for new features or functionality labels Aug 12, 2024
@anthonykim1 anthonykim1 added the skip tests Updates to tests unnecessary label Aug 12, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review August 12, 2024 22:52
TylerLeonhardt
TylerLeonhardt previously approved these changes Aug 12, 2024
View reviewed changes
@anthonykim1 @karthiknadig
Update src/client/terminals/codeExecution/terminalReplWatcher.ts
f89a071 
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
@anthonykim1 anthonykim1 merged commit c13bb07 into microsoft:main Aug 13, 2024
40 checks passed
@anthonykim1 anthonykim1 mentioned this pull request Aug 13, 2024
Merged
anthonykim1 added a commit that referenced this pull request Aug 13, 2024
@anthonykim1
Fire telemetry when REPLs are launched via shift+enter (#23944)
b872cb4 
Related to #23740
In addition to : #23941 

Fire telemetry for when REPL is launched via shift+enter. 
/cc @cwebster-99
@anthonykim1 anthonykim1 mentioned this pull request Aug 16, 2024
Merged
anthonykim1 added a commit that referenced this pull request Aug 16, 2024
@anthonykim1
Fix telemetry not getting picked up for Terminal REPL (#23958)
e9f1071 
#23941 
Having no blank spaces in front of plain 'python' or 'python3' were
returning falsey value.
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this pull request Sep 13, 2024
@anthonykim1
Fix telemetry not getting picked up for Terminal REPL (microsoft#23958)
1641506 
microsoft#23941 
Having no blank spaces in front of plain 'python' or 'python3' were
returning falsey value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

Assignees

@anthonykim1 anthonykim1

Labels
area-repl area-terminal feature-request Request for new features or functionality skip tests Updates to tests unnecessary
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

Add telemetry when python terminal REPL is used
3 participants
@anthonykim1 @TylerLeonhardt @karthiknadig