Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new JUnit XML format. #7265

Merged

Conversation

ericsnowcurrently
Copy link
Member

(for #6990)

The JUnit XML format used by pytest was updated in version 5.1.0. This PR adds support for that format, and falls back to the old one.

This branch builds on PR #7263 and includes the actual fix for #6990. Please review commits after e58922a.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #7265 into master will increase coverage by 0.69%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7265      +/-   ##
==========================================
+ Coverage   57.99%   58.69%   +0.69%     
==========================================
  Files         494      494              
  Lines       21472    21838     +366     
  Branches     3493     3503      +10     
==========================================
+ Hits        12452    12817     +365     
+ Misses       8221     8220       -1     
- Partials      799      801       +2
Impacted Files Coverage Δ
src/client/testing/common/xUnitParser.ts 62.5% <53.33%> (-3.61%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/process/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/dotnet/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/linters/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f69bf7...d523f13. Read the comment docs.

@ericsnowcurrently ericsnowcurrently merged commit 6a57280 into microsoft:master Sep 19, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-6990-pytest-5.1 branch September 19, 2019 23:08
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants