Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

[Discussion] [Live Share] Restricting linting to local files #338

Closed
wants to merge 1 commit into from
Closed

[Discussion] [Live Share] Restricting linting to local files #338

wants to merge 1 commit into from

Conversation

lostintangent
Copy link
Member

In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services from a host, this PR simply updates the current DocumentSelector to be limited to file and untitled (unsaved) files. This way, when someone has the TSLint extension installed, and joins a Live Share session (where files use the vsls: scheme), their language services will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience.

// CC @egamma

@egamma egamma added this to the April 2018 milestone Apr 12, 2018
@egamma
Copy link
Member

egamma commented Apr 12, 2018

@lostintangent thanks for the PR.
Since, tslint doesn´t support untitled files. I´ve inlined the document selector defintion rather than using flatMap. This also doesn´t introduce a dependency on lodash.

		documentSelector: [
			{ language: 'typescript', scheme: 'file' },
			{ language: 'typescriptreact', scheme: 'file' },
			{ language: 'javascript', scheme: 'file' },
			{ language: 'javascriptreact', scheme: 'file' }
		],

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants