Apply PR feedback

microsoft · Sep 1, 2021 · 320e043 · 320e043
1 parent 8e55780
commit 320e043
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/vs/code/node/cli.ts b/src/vs/code/node/cli.ts
@@ -360,7 +360,7 @@ export async function main(argv: string[]): Promise<any> {
 				openArgs.push('--stderr', tmpStderrName);
 			}
 			const argsArr: string[] = [];
-			const isDev = env['NODE_ENV'] === 'development';
+			const isDev = env['VSCODE_DEV'];
 			// When we're in development mode, call the OSS app rather than the OSS app's Electron
 			const execPathToUse = isDev ? resolve(join(process.execPath, '../../..')) : process.execPath;
 			argsArr.push('-a', execPathToUse);

diff --git a/src/vs/code/node/cliVerboseLogger.ts b/src/vs/code/node/cliVerboseLogger.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { ChildProcess } from 'child_process';
-import { watch, writeFileSync } from 'fs';
+import { watch, writeFileSync, unlinkSync } from 'fs';
 import { Promises } from 'vs/base/node/pfs';
 
 /**
@@ -42,6 +42,7 @@ export class CliVerboseLogger {
 			}).finally(() => {
 				Promises.close(fileHandle);
 				watcher.close();
+				unlinkSync(this.filename);
 			});
 		};
 	}