Wrong highlight if there are duplicate strings in completion item

[HaoboGu]

• VSCode Version: 1.52.1
• OS Version: MacOS Big Sur 11.1

If a suggestion contains two "div", the second "div" is wrongly highlighted after "di" is entered

Does this issue occur when all extensions are disabled?: No, with my customed completion extension

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Onclick div it will show outer div boundary instead of current div (#70316)
• Emmet expression with attributes not expanding (#92231)
• [folding] Folding HTML tags should hide the closing tag. (#24515)

[HaoboGu]

@jrieken I'd like to open a PR to fix it, would you please give me some hints about where can I start?

[HaoboGu]

Steps to reproduce it:

1. Create an extension, use the following extension.ts

import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	const provider1 = vscode.languages.registerCompletionItemProvider('plaintext', {
		provideCompletionItems(document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken, context: vscode.CompletionContext) {
			const simpleCompletion = new vscode.CompletionItem('⭐div classname=""></div>');
			return [simpleCompletion];
		}
	}, ' ', '.', '<');
	context.subscriptions.push(provider1);
}

export function deactivate() {}

2. Set activateEvent in package.json:

"activationEvents": [
		"*"
	],

3. open a txt and enter character "d"
   

only the later "d" is highlighted

[jrieken]

Understood. Our fuzzy score function treats certain characters as separators, like _ and .. However, emojis and such aren't on that list. The code is here:

vscode/src/vs/base/common/filters.ts

Line 466 in 696dca7

function isSeparatorAtPos(value: string, index: number): boolean {

[HaoboGu]

Understood. Our fuzzy score function treats certain characters as separators, like _ and .. However, emojis and such aren't on that list.

@jrieken Thanks for the hint! Here is another case, the later match of di is highlighted even though the first character is not emoji nor symbol.

It seems that just adding emoji or symbols to isSeparatorAtPos couldn't solve the entire problem.

[jrieken]

That is a different case. Having adiv and di isn't match for us because the first match (d in ad) is considered weak. A strong match is one after a separator or a the word start and matches much start with a strong match.

[HaoboGu]

So the adiv case is by design, right?

[jrieken]

yes, see here #53715

[HaoboGu]

Thanks, I'll open a PR to fix the emoji case ;D

[connor4312]

This doesn't seem to be working for me in the latest Insiders. I don't see the highlight after the emoji, and the match doesn't come up if I start typing div in a suggestion that contains only ⭐div

[HaoboGu]

This doesn't seem to be working for me in the latest Insiders. I don't see the highlight after the emoji, and the match doesn't come up if I start typing div in a suggestion that contains only ⭐div

Can you try other emoji like ✨ ？
In my insiders it works:

It seems that '⭐' is not included by

vscode/src/vs/base/common/strings.ts

Lines 776 to 782 in 5da5495

	export function isEmojiImprecise(x: number): boolean {
	return (
	(x >= 0x1F1E6 && x <= 0x1F1FF) || (x >= 9728 && x <= 10175) || (x >= 127744 && x <= 128591)
	|| (x >= 128640 && x <= 128764) || (x >= 128992 && x <= 129003) || (x >= 129280 && x <= 129535)
	|| (x >= 129648 && x <= 129651) || (x >= 129656 && x <= 129666) || (x >= 129680 && x <= 129685)
	);
	}

[HaoboGu]

@alexdima do you have any suggestions on it? I would like to fix isEmojiImprecise if possible

[jrieken]

Not critical for this release, moving to February

[alexdima]

I've created #115221 to track the isEmojiImprecise problem.

[connor4312]

I can verify it works with ✨, so I'll close this and mark as verified pending Alex's new issue