Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LanguageFeatureRequestDelays easier to use and adopt in more places #140557

Closed
10 tasks done
jrieken opened this issue Jan 12, 2022 · 6 comments
Closed
10 tasks done

Make LanguageFeatureRequestDelays easier to use and adopt in more places #140557

jrieken opened this issue Jan 12, 2022 · 6 comments
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
February 2022

Comments

@jrieken
Copy link
Member

jrieken commented Jan 12, 2022 •
edited by aeschli
Loading

We have adaptive debouncing logic implemented in LanguageFeatureRequestDelays. We should make this so that it can be used in more places easier. Identified the following pieces

  • a better sliding window average instead of "forever move average"
  • in all providers, to save on bandwidth, if a request is canceled, throw canceled instead of returning results
  • adopt ILanguageFeatureDebounceService#for in more providers e.g.
@jrieken jrieken self-assigned this Jan 12, 2022
@jrieken jrieken added this to the January 2022 milestone Jan 12, 2022
jrieken added a commit that referenced this issue Jan 12, 2022
@jrieken
add raceCancellationError-util, tweak raceCancellation-util as well, #…
7855392 
…140557
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 12, 2022
vscode: add raceCancellationError-util, tweak raceCancellation-util a…
8e59c01 
…s well, microsoft/vscode#140557

Commit: 7855392ed42218367435398c2c4e5d1c983ad771
jrieken added a commit that referenced this issue Jan 12, 2022
@jrieken
allow to race against cancellation when invoking _withAdapter, neve…
e5703c8 
…r log cancellation errors, #140557
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 12, 2022
vscode: allow to race against cancellation when invoking `_withAdapte…
bae5af4 
…r`, never log cancellation errors, microsoft/vscode#140557

Commit: e5703c84055ecc014bc5d3ccd342e5bed475fff0
jrieken added a commit that referenced this issue Jan 12, 2022
@jrieken
use "sliding window" average for language feature delays, #140557
c79dcf8
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 12, 2022
vscode: use "sliding window" average for language feature delays, mic…
8c50215 
…rosoft/vscode#140557

Commit: c79dcf8c5c162168562d491c520bee585c1bdf01
@jrieken jrieken added engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality labels Jan 12, 2022
jrieken added a commit that referenced this issue Jan 13, 2022
@jrieken
move LanguageFeatureRequestDelays into `ILanguageFeatureDebounceSer…
0cfa366 
…vice`, have better defaults, and adopt for code lens and inlay hints, #140557
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 13, 2022
vscode: move LanguageFeatureRequestDelays into `ILanguageFeatureDeb…
e62d799 
…ounceService`, have better defaults, and adopt for code lens and inlay hints, microsoft/vscode#140557

Commit: 0cfa366323337aec7c18969b56a7a505a1904bd2
jrieken added a commit that referenced this issue Jan 14, 2022
@jrieken
do away with dynamic default value, #140557
2e7075d
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 14, 2022
vscode: do away with dynamic default value, microsoft/vscode#140557
948ddde 
Commit: 2e7075d5c503613069476e64b69f89f9d71ba213
@jrieken jrieken mentioned this issue Jan 14, 2022
Closed
jrieken added a commit that referenced this issue Jan 17, 2022
@jrieken
use ILanguageFeatureDebounceService for outline model, #140557
4135ba2
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 17, 2022
vscode: use ILanguageFeatureDebounceService for outline model, micr…
af76107 
…osoft/vscode#140557

Commit: 4135ba294b4027440523ed3383ba6f56049e776e
@jrieken
Copy link
Member Author

jrieken commented Jan 18, 2022 •
edited by weinand
Loading

@alexdima @aeschli Please adopt the ILanguageFeatureDebounceService in your "ambient editor" features, like folding ranges and semantic tokens. The service allows you get debounce information (some dynamic average) for a feature registry, see inlay hints here

jrieken added a commit that referenced this issue Jan 18, 2022
@jrieken
In the ext-host, race goto-symbol features against cancellation, #140557
19e3ef4
jrieken added a commit that referenced this issue Jan 18, 2022
@jrieken
on the ext-host, race call and type hierarchy against cancellation so…
57eaad7 
… save bandwidth, #140557
jrieken added a commit that referenced this issue Jan 18, 2022
@jrieken
on ext-host race selection ranges, workspace symbols, and document sy…
56a830b 
…mbols against cancellation, #140557
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 18, 2022
vscode: In the ext-host, race goto-symbol features against cancellati…
46c4cbf 
…on, microsoft/vscode#140557

Commit: 19e3ef41bdfe738894272a8619c72a85f34c6563
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 18, 2022
vscode: on the ext-host, race call and type hierarchy against cancell…
b07be2d 
…ation so save bandwidth, microsoft/vscode#140557

Commit: 57eaad7de3aea816f8ba2c47115f036159b06bb3
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 18, 2022
vscode: on ext-host race selection ranges, workspace symbols, and doc…
5ce0693 
…ument symbols against cancellation, microsoft/vscode#140557

Commit: 56a830bc6825a30c03448cbb2bf616abb252a200
jrieken added a commit that referenced this issue Jan 18, 2022
@jrieken
make token to race against mandatory optional, #140557
7718b8e
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 18, 2022
vscode: make token to race against mandatory optional, microsoft/vsco…
0e18705 
…de#140557

Commit: 7718b8ef728959eb2167e94ac24c823e9bc79d73
@egamma egamma mentioned this issue Jan 18, 2022
Closed
91 tasks
jrieken added a commit that referenced this issue Jan 20, 2022
@jrieken
add trace logging for language feature debounce rates, #140557
3c601f1
@jrieken
Copy link
Member Author

jrieken commented Jan 21, 2022

@aeschli created PR #141162 which adopts this for folding

jrieken added a commit that referenced this issue Jan 24, 2022
@jrieken
allow to pass max-delay to debounce info, defaults to min^2 millis, #…
f9e9120 
…140557, fyi @alexdima
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 24, 2022
vscode: allow to pass max-delay to debounce info, defaults to min^2 m…
16404d7 
…illis, microsoft/vscode#140557, fyi @alexdima

Commit: f9e91209d439cec71fee9dfa6e56c7a1aa1af5d2
alexdima added a commit that referenced this issue Jan 24, 2022
@alexdima
Adopt ILanguageFeatureDebounceService for invoking `DocumentSemanti…
4c876b8 
…cTokensProviderRegistry` (#140557)
alexdima added a commit that referenced this issue Jan 24, 2022
@alexdima
Adopt ILanguageFeatureDebounceService for invoking `DocumentRangeSe…
18aa226 
…manticTokensProviderRegistry` (#140557)
@jrieken jrieken modified the milestones: January 2022, February 2022 Jan 26, 2022
@jrieken
Copy link
Member Author

jrieken commented Jan 26, 2022

Moving this to February for more cancellation token adoption

jrieken added a commit that referenced this issue Feb 3, 2022
@jrieken
more cancellation handling on the ext host, #140557
f933065
@jrieken
Copy link
Member Author

jrieken commented Feb 4, 2022

fyi @aeschli readded you for more ambient editor features: colors, linked editing

alexdima added a commit that referenced this issue Feb 4, 2022
@alexdima
Adopt ILanguageFeatureDebounceService (#140557)
60e3e1a
@alexdima alexdima removed their assignment Feb 4, 2022
@kieferrm kieferrm mentioned this issue Feb 7, 2022
Closed
81 tasks
hediet added a commit that referenced this issue Feb 8, 2022
@hediet
Adopts ILanguageFeatureDebounceService#for for inline completions. See …
05524c8 
…#140557.
@hediet hediet removed their assignment Feb 8, 2022
@hediet
Copy link
Member

hediet commented Feb 8, 2022

I think some documentation of that service wouldn't hurt.
Why does adoption make sense? (After I talked to you I now know why)

@weinand weinand closed this as completed in bd74418 Feb 8, 2022
@weinand weinand reopened this Feb 8, 2022
@weinand weinand removed their assignment Feb 8, 2022
aeschli added a commit that referenced this issue Feb 8, 2022
@aeschli
linked editing: adopt ILanguageFeatureDebounceService. For #140557
0119d8c
aeschli added a commit that referenced this issue Feb 8, 2022
@aeschli
document colors: adopt ILanguageFeatureDebounceService. For #140557
7cd4ac5
@aeschli aeschli removed their assignment Feb 9, 2022
@jrieken jrieken closed this as completed Feb 10, 2022
@jrieken
Copy link
Member Author

jrieken commented Feb 10, 2022

Thanks everyone!

@jrieken jrieken removed the feature-request Request for new features or functionality label Feb 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
6 participants
@jrieken @weinand @hediet @alexdima @aeschli and others