Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative dimension of TOC is not preserved when window is resized #143690

Closed
stevencl opened this issue Feb 23, 2022 · 2 comments · Fixed by #145358
Closed

Relative dimension of TOC is not preserved when window is resized #143690

stevencl opened this issue Feb 23, 2022 · 2 comments · Fixed by #145358
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@stevencl
Copy link
Member

Testing #143138

Maximize the VS Code window
Resize the TOC so that it is approximately a quarter of available screen real estate
Unmaximize the VS Code window
Reduce the width of the VS Code window until the TOC disappears
Increase the width of the VS Code window until it is the same width as before the previous step
Expected: TOC should be the same width (quarter of available screen real estate)
Actual: TOC is set to narrowest possible width

Recording 2022-02-23 at 10 24 40

@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Feb 23, 2022
@rzhao271 rzhao271 added this to the March 2022 milestone Feb 23, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 24, 2022

An issue is the Settings editor remembers that the last width was the min width.
Also, when the user slowly rewidens the editor, the ToC first shows back up at the min width, rather than a larger previous width.
I'll change the proportional layout to true for now, so that when you widen the window, both sides of the splitview widen.

@rzhao271
Copy link
Contributor

Verification steps:

  1. Widen the VS Code window while looking at the Settings editor so that the table of contents is visible. While widening the window more, both the table of contents on the left and the settings list on the right should grow in width proportionally.
  2. Shrink the VS Code window in width so that the table of contents goes away. Then, slowly widen the window again. When the table of contents shows up, the table of contents shouldn't be at its most narrow possible width by default, and the vertical sash should have around 100px of movability.

@mjbvz mjbvz added the verified Verification succeeded label Mar 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@stevencl @rzhao271 @mjbvz and others