Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arrow to revert changes in diff editor interferes with setting breakpoints from diff editor #152115

Closed
joyceerhl opened this issue Jun 14, 2022 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.69-insider
  • OS Version: Windows 11

Steps to Reproduce:

  1. Have some diff

  2. Notice that on all lines but the first, hovering in the gutter allows you to set a breakpoint. On the first line there is now an arrow, which appears to have come in through Arrows to revert changes in side by side diff editor #151826:
    image

  3. 🐛 the arrow doesn't have a tooltip which makes it hard to tell what it's for or where it came from (I figured it out by inspecting the element).

  4. 🐛 this makes it impossible to set breakpoints on the first line of a diff from the diff editor, which is something that I use a fair bit. Could we consider having this action show up somewhere else (e.g. in a codelens), or having a setting to disable this action?

Additionally, I'd like to suggest the discard codicon. We use this for git reverts, and IMO it's more intuitively related to reverting a change (I was initially a little surprised by what the right arrow button did)

@yume-chan
Copy link
Contributor

refs #25887

the arrow doesn't have a tooltip

#152088

@alexdima alexdima added this to the June 2022 milestone Jun 15, 2022
@hediet
Copy link
Member

hediet commented Jun 15, 2022

@Mingpan do you have ideas for this?

@Mingpan
Copy link
Contributor

Mingpan commented Jun 17, 2022

@Mingpan do you have ideas for this?

I don't know if there is a way to make both "revert change" and breakpoints work in the same line. But I think a setting to disable "revert change" sounds very reasonable. +1 to it.

suggest the discard codicon

I think the right arrow is supposed to indicate "move / copy what's on the left to the right side". I feel like it's a common practice when working with side-by-side views? But changing it could also be reasonable if more people prefer discard icon, or if it's a UX decision due to consistency reason within VS Code.

@hediet
Copy link
Member

hediet commented Jun 17, 2022

I actually prefer the arrow. But a tooltip and a setting to disable that might indeed be helpful. We are open for a PR here ;)

@Mingpan
Copy link
Contributor

Mingpan commented Jun 17, 2022

I actually prefer the arrow. But a tooltip and a setting to disable that might indeed be helpful. We are open for a PR here ;)

Happy to add a setting for it :) I also want to fix one miss from myself... #152165 (sorry about that)

Tooltip is definately helpful. I will also see if I might be able to do it - it feels like a general improvement needed, which is tracked by #152088

@AnrDaemon
Copy link

Ref to #3130

@hediet
Copy link
Member

hediet commented Jun 21, 2022

Happy to add a setting for it :)

That would be great!

Tooltip is definately helpful. I will also see if I might be able to do it - it feels like a general improvement needed, which is tracked by #152088

That would be very helpful if there is an easy fix.

Thanks a lot!

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants