Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for disable arrows in diff #153199

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

Mingpan
Copy link
Contributor

@Mingpan Mingpan commented Jun 25, 2022

This PR fixes:

This PR adds a config setting for diff editor. The setting allows user to disable revert change icons in the glyph margin of a side-by-side diff editor.

CC @hediet

Some additional notes:

  • I implemented this in a way that's similar to other existing settings in diffEditorWidget.ts, please let me know if some other pattern is preferred instead.
  • Tooltips for glyph margin icons / decorations is not covered in this PR. A separate issue tracks it.

Please let me know if there's anything in the code that needs fixes / improvements. Thanks!

@hediet hediet requested a review from alexdima June 27, 2022 13:44
@hediet
Copy link
Member

hediet commented Jun 27, 2022

Thanks a lot for the PR!

@hediet hediet added this to the June 2022 milestone Jun 27, 2022
@alexdima alexdima merged commit 0a3ca02 into microsoft:main Jun 27, 2022
@masterwishx
Copy link

i cant see arrow in diff for copy changes ...

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants