-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Use Fuzzy Search" button toggle - a weird UI pattern #156322
Comments
Yes we agree and have had discussions about a better icon that aligns with other toggles |
This is also being tracked in #156179 where we're looking at all of the inputs w/ actions/toggles |
Depends on #156179 |
UX sync feedback: Prefer a toggle over a dropdown as it's a search mode/how it's search, vs a dropdown which is typically what is searched/filtered. It seems the consensus was some icon similar to this to mean "fuzzy search", we can also avoid mentioning "default"/"continuous"/"contiguous" if it's a toggle. We may want the fuzzy search toggle to be remembered and/or in a setting, fzf users may want fuzzy search by default. |
Wouldn't it be better to display what it actually does like we do with the |
Icon request: microsoft/vscode-codicons#132 |
By having it underline either a continuous segment or separate ones |
@meganrogge that was the idea behind these ones: The idea seemed solid but I think in practice they are pretty ugly |
I far prefer those because it tells me what's going on. The other makes me think of zoom |
Yeah but a button's icon should indicate what it does - the button doesn't search - it changes the type of filter used |
IMO, that's precisely why it's confusing - I'm already searching via the input box - not sure what a search with a squiggly line will do |
@meganrogge fuzzy search is more of a search mode which are typically represented as toggled. Usually filters (the dropdown) refine the search space, so a filter-like icon isn't appropriate here imo.
It defines how a search happens, so the icon indicates search + a modifier which is a fuzzy line. @misolori revisiting those ideas that @meganrogge prefers, the second one seems decent and not too busy, what do you think? Maybe better with |
I think those are very minor/small changes that users might confuse them with "Match Whole Word", and I think the feedback from the UX sync was those wouldn't work as best. Are we trying to re-visit the icon itself again? I don't think we're going to find an icon that best represents it as it's a hard concept to encapsulate in an icon. I think we should try the one we just merged in and see what the feedback is. |
Add `search-fuzzy` (Refs microsoft#156322)
To verifier: Verify the toggle works as expected/like the button before it |
Testing #156002
I find it weird that the "Use Fuzzy Search" is a big blue button. I think it would be styled more like the toggles in the editor find widget. Or it should be a checkbox.
The blue button is too strong, and I would expect that it executes something a closes the quick pick
fyi @misolori
The text was updated successfully, but these errors were encountered: