Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate smart diffing algorithm in favor of experimental diffing algorithm #164583

Closed
4 tasks done
hediet opened this issue Oct 25, 2022 · 0 comments · Fixed by #180310
Closed
4 tasks done

Deprecate smart diffing algorithm in favor of experimental diffing algorithm #164583

hediet opened this issue Oct 25, 2022 · 0 comments · Fixed by #180310
Assignees
@hediet
Labels
debt Code quality issues diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders
Milestone
April 2023

Comments

@hediet
Copy link
Member

hediet commented Oct 25, 2022 •
edited
Loading

Once the experimental algorithm is on par with the smart diffing algorithm, we should deprecate the smart diffing algorithm and also use the experimental one in the side by side diff view (and also rename it).

@alexdima

Blockers:

  • Check worst-case performance
  • Ignore Whitespace Option
  • Consider timeout
  • Don't split up words too much

Advantages:

  • Stable diffing algorithm, clean code
  • Insertion optimizations
  • Better scoring due to dynamic programming algorithm in some cases

Would:
@hediet hediet added debt Code quality issues diff-editor Diff editor issues labels Oct 25, 2022
@hediet hediet added this to the Backlog milestone Oct 25, 2022
@hediet hediet self-assigned this Oct 25, 2022
@hediet hediet mentioned this issue Oct 25, 2022
Closed
@hediet hediet modified the milestones: Backlog, April 2023 Mar 22, 2023
@kieferrm kieferrm mentioned this issue Apr 2, 2023
Closed
90 tasks
hediet added a commit that referenced this issue Apr 19, 2023
@hediet
Fixes #164583. Renames diffAlgo name smart to legacy and experimental…
fc8f0a9 
… to advanced.
@hediet hediet mentioned this issue Apr 19, 2023
Merged
hediet added a commit that referenced this issue Apr 19, 2023
@hediet
Fixes #164583. Renames diffAlgo name smart to legacy and experimental…
ca2f9e8 
… to advanced.
hediet added a commit that referenced this issue Apr 19, 2023
@hediet
Fixes #164583. Renames diffAlgo name smart to legacy and experimental…
7395a78 
… to advanced. (#180310)
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
debt Code quality issues diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Fixes #164583. Renames diffAlgo name smart to legacy and experimental to advanced. microsoft/vscode
2 participants
@hediet @vscodenpa