Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve awareness of debug location in notebooks #169190

Closed
roblourens opened this issue Dec 15, 2022 · 1 comment
Closed

Improve awareness of debug location in notebooks #169190

roblourens opened this issue Dec 15, 2022 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality notebook-debugging verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Dec 15, 2022

It's easy to lose track of the debugged cell in notebooks, especially when you've stepped into a cell which is different from the cell that is "running". Some improvements we could make:

  • The "Go To" button should go to the cell at the top of the callstack, not the cell where the user clicked Run
  • We should show overview ruler decorations for the top stackframe, as in the editor
  • And overview ruler decorations for the currently running cell
  • And for breakpoints (behind a setting, debug.showBreakpointsInOverviewRuler)

cc @kieferrm

@roblourens roblourens added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues notebook-debugging labels Dec 15, 2022
@roblourens roblourens added this to the Backlog milestone Dec 15, 2022
@roblourens roblourens self-assigned this Dec 15, 2022
@roblourens roblourens modified the milestones: Backlog, January 2023 Dec 16, 2022
roblourens added a commit that referenced this issue Jan 20, 2023
* Add cell decoration for the currently executing cell
Part of #169190

* Split out to own file
roblourens added a commit that referenced this issue Jan 20, 2023
@roblourens roblourens added the verification-needed Verification of issue is requested label Jan 24, 2023
@roblourens
Copy link
Member Author

To verify, just try everything listed at the top.

For

the cell at the top of the callstack, not the cell where the user clicked Run

I mean, have two cells, like

def foo():
    print('hello')

and a second cell that calls foo(). Set a breakpoint in the function definition, click run on the second cell, and make sure "Go To" goes to that first cell where the instruction pointer is.

@connor4312 connor4312 added the verified Verification succeeded label Jan 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality notebook-debugging verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @connor4312 and others